This action will delete this post on this instance and on all federated instances, and it cannot be undone. Are you certain you want to delete this post?
This action will delete this post on this instance and on all federated instances, and it cannot be undone. Are you certain you want to delete this post?
This action will block this actor and hide all of their past and future posts. Are you certain you want to block this actor?
This action will block this object. Are you certain you want to block this object?
#crystallang 28 hashtags
Crystal is fast because methods are monomorphized at compile time. In simple terms, that means that at compile time, a polymorphic method is replaced by one or more type-specific instantiations of that method. The following polymorphic code...
def plus(x, y) x + y end
...is effectively replaced by two methods—one that does integer addition if called with two integers, and one that does string concatenation if called with two strings.
This extends to inherited methods, which are implicitly also passed self
. You can see this in action if you dump and inspect the symbols in a compiled program:
class FooBar def self.foo puts "#{self}.foo" end def bar puts "#{self}.bar" end end FooBar.foo FooBar.new.bar class Quux < FooBar end Quux.foo Quux.new.bar
Dumping the symbols, you see multiple instantiations of the methods foo
and bar
:
... _*FooBar#bar:Nil _*FooBar::foo:Nil _*FooBar@Object::to_s<String::Builder>:Nil _*FooBar@Reference#to_s<String::Builder>:Nil _*FooBar@Reference::new:FooBar _*Quux@FooBar#bar:Nil _*Quux@FooBar::foo:Nil _*Quux@Object::to_s<String::Builder>:Nil _*Quux@Reference#to_s<String::Builder>:Nil _*Quux@Reference::new:Quux ...
The optimizer in release builds is pretty good at cleaning up the obvious duplication. But during my optimization work on Ktistec, I found that a lot of duplicate code shows up anyway.
Most pernicious are weighty methods that don't depend on class or instance state (don't make explicit or implicit reference to self
). As I blogged about earlier, this commit replaced calls to the inherited method map
on subclasses with calls to the method map
defined on the base class and reduced the executable size by ~5.8%. The code was identical and the optimizer could remove the unused duplicates.
So, as a general rule, if you intend to use inheritance, put utility code that doesn't reference the state or the methods on the class or instance in an adjacent utility class—as I eventually did with this commit.
(The full thread starts here.)
Ktistec release v2.4.5 rolls out the build time and executable size optimizations I've been blogging about here. It also fixes a few small bugs.
Fixed
Changed
I've started a branch full of query optimizations. My general rule—as highlighted in the server logs—is if a query takes longer than 50msec, it takes too long. It's time to address some problems...
The Ktistec executable is now ~24.7% smaller and build times are 28% faster.
I've been blogging about optimizations here, here, and here. This is the summary of the final outcome, with links to commits for the curious. I have one more post planned with a summary of my thoughts.
Here's my approach. Use nm
to dump the symbols in a release build executable and then look for things that seem redundant. The first change and associated post below is a great example of what I mean—my original implementation led to the specialization of the #==
method for every pairwise combination of model classes even though the result of the comparison was just false
.
This might seem like a strange approach if you come from a compiled language where you mostly write all of the code yourself or invoke generics explicitly, but Crystal takes your code and does that for you. And it's not always obvious up front (to me, at least) what the final cost will be.
I've include counts of the lines added/removed because the point of this whole post is to say if you measure first and then optimize, a small change can have a big impact.
Here are the changes:
#==
. (+7 -5)Hash
. (+2 -2)__for_internal_use_only
that get passed both named tuples and hashes by going all in with named tuples. It also eliminates instantiations of the Hash
generic type itself for these cases. Reduces executable size by ~2.2%.__for_internal_use_only
entirely.InstanceMethods
instance methods. (+1 -5)map
from base ActivityPub model classes. (+10 -2)map
is a class method defined on each ActivityPub base model class. Each definition maps JSON-LD to a hash that is used to instantiate the class. Class methods defined on a base class are available on subclasses, as well. Calling the method on the subclass results in a copy of the method. This change reduces the executable size by ~5.8%.map
into helper. (+104 -88) map
method does not depend on class/instance state. This change ensures that the mapping code is not duplicated even if a subclass's map
method is accidentally again called. It looks like a lot of changes but this commit is mostly reorganization. It reduces executable size by ~0.4%.I'm off to optimize some queries now...
The prologue to this post, and other posts in the series, is here.
Investigating commit b65d292f was fruitful but not for obvious reasons.
Dumping the symbols (nm -j server
) before and after the commit showed large number of new equality (==
) methods. From the diff:
1765a1772 > _*ActivityPub::Activity::Accept#==<Translation>:Bool 1920a1928 > _*ActivityPub::Activity::Add#==<Translation>:Bool 2062a2071 > _*ActivityPub::Activity::Announce#==<Translation>:Bool 2237a2247 > _*ActivityPub::Activity::Block#==<Translation>:Bool ...
The use, in a controller action, of the new Translation
model seemingly triggered their generation. What was going on?
A long time ago I implemented a MVC model framework in the style of ActiveRecord (2de4a4b3) and it included a method for testing for equality. Note the method signature.
# Returns true if all properties are equal. # def ==(other : self) {% begin %} {% vs = @type.instance_vars.select(&.annotation(Persistent)) %} if {% for v in vs %} self.{{v}} == other.{{v}} && {% end %} self.id == other.id true else false end {% end %} end
The Reference
class—the default parent for classes—defines two base implementations of this method: one that tests for identity (not equality), with the signature def ==(other : self)
, and another that returns false
, with the signature def ==(other)
. When I implemented my method, my assumption was: redefine the former for model classes and let the latter take care of everything else. This assumption was incorrect.
In circumstances that I still don't completely understand, the compiler will generate calls to the latter (the method that just returned false
) when it "should have" been calling the former, and comparisons failed when they should have succeeded. I "fixed this" with commit effeaa26 that removed the type restriction and explicitly handled the type check. Everything worked!
The problem is Crystal creates a version of this method for every possible model comparison, specialized by both self
and other
. Most of the time the type check fails and the method returns false
. But the rest of the code is still present.
The fix (re)adds a method specialization that returns false
and lets the compiler handle the type check.
# Returns `false`. # def ==(other) false end
Because this method just returns a constant value, the compiler gets rid of the method call, as well.
Interestingly, this change reduced the size of the Ktistec server executable by 4.0% when building without the --release
flag but only 0.2% when building with it, so optimization does a good job at cleaning this up even without the change.
what's the union of all errors that a call like HTTP::Client.get(...)
(in Crystal) might raise?
i typically rescue IO::Error
(which gets hostname lookup and socket connection problems), OpenSSL::Error
(which gets a few edge-case problems with SSL configuration on the other end), Compress::Deflate::Error
and Compress::Gzip::Error
(which gets a few even more edge-case configuration problems on the other end), and URI::Error
.
what am i missing?
Ktistec release v2.4.4 fixes a few things in the prior release and introduces at least one killer feature!
Fixed
Changed
I'm spending some cycles looking at the size of the server executable. You can read about my approach to reducing Crystal Language executable size and build time here.
The prologue to this post is here.
Investigating commit e2327eea might be a bust.
I dumped the symbols before and after this change. The new symbols were all specializations of the core library Hash
class introduced by adding JSON parsing support for the "language" property.
So what does that mean and why is this commit a dead end?
You can think of Crystal classes and methods as being implicitly generics. If you have a method foo
with one parameter bar
and call it with an Array
, Crystal creates a version of that method specialized to handle an Array
type as an argument. If you call it with a Hash
, Crystal creates another version of that method specialized to handle a Hash
type as an argument. If the method has 20 lines of code, you effectively get two copies of those 20 lines of code. There is no runtime polymorphic dispatch, which is one of the reasons Crystal is so fast. You can make all of this explicit with Crystal type restrictions, method overloading, and generics, of course, but you don't have to.
This path is a dead end (for now) because any improvements that I can see that I can make (replacing hash construction with a more fluent sequence of attribute assignments) will need to be made to other classes where this is a problem, and there are only a few of those, so the net potential for improvement seems small.
After I release a new version of ktistec, I build the server commit-by-commit to see which commits increase the server executable size and build time the most. I do this because I’ve learned that small implementation details (inlined code, small methods, using blocks) can have large impacts on these numbers.
Here's the output:
Commit Size Time ======== ========== ======= ===== ======= 248850b1 36426264 10.3 47268073 36425688 -0.00% 10.5 +1.60% 344de272 36425688 +0.00% 10.8 +3.24% ef561f52 36425944 +0.00% 10.8 -0.08% 8ae2cbd4 36429128 +0.01% 10.8 -0.01% 3e425f3b 36429128 +0.00% 10.8 +0.22% 1487d903 36427704 -0.00% 11.0 +1.42% 935c9ceb 36427016 -0.00% 11.0 +0.14% de37dc6a 36427016 +0.00% 10.9 -0.97% a660a326 36427016 +0.00% 10.8 -1.12% ff3d990e 36427016 +0.00% 10.8 +0.54% 5724a58d 36523192 +0.26% 11.0 +1.78% 7b5057d4 36523640 +0.00% 11.0 -0.44% 30ca6a3f 36541352 +0.05% 11.6 +5.73% e2327eea 36671592 +0.36% 11.0 -5.36% ad0d76eb 36671592 +0.00% 10.9 -0.48% d388e74f 36671592 +0.00% 11.4 +4.59% dacea7ad 36671592 +0.00% 11.0 -3.76% 03d5dfd8 36671592 +0.00% 10.8 -1.63% 79d9d89f 36671576 -0.00% 11.0 +1.82% b65d292f 36792376 +0.33% 11.1 +0.95% 0ef53365 36808904 +0.04% 11.6 +4.88% b3766e7b 36808904 +0.00% 11.1 -4.50% 56ba79ce 36825416 +0.04% 11.1 -0.50% 4824df58 36825736 +0.00% 11.1 +0.31% c4705143 36837544 +0.03% 11.1 -0.03% e3d37ef7 36837768 +0.00% 11.5 +3.52% 4509fa0d 36837768 +0.00% 11.0 -3.83% 0ff9237b 36837768 +0.00% 11.0 -0.55%
Overall, the server executable size increased by about 1.1% and the build time increased by about 6.8%. Maybe that's not too bad for a major feature, but let's dig in.
It's nice to see that three commits account for almost all of the increase in server executable size:
But, compare 5724a58d to 8ae2cbd4 (Add `language` to `Account`). It added +22 loc but didn't increase the server executable size as much.
In any case, I'll look at e2327eea first. I'd like to understand why this relatively small change adds 130,240 bytes to the server executable size!
Ktistec release v2.4.3 supports language translation.
Inspiration for this feature comes from Mastodon.
In order to enable translation, you need an API key for either DeepL or LibreTranslate. These are the only services Ktistec supports at this time.
Posts from properly configured accounts on supported servers, like Mastodon, include the content language. On posts like these, Ktistec will display a button to translate the content if the language differs from your language.
Unfortunately, not all Fediverse/ActivityPub servers explicitly support language (I mean, Ktistec didn't until just now). And not all users correctly set their posts' language, so ymmv... but it has been hugely useful for me.
I'm going to focus on site customization next (colors, etc.).
Release v2.4.2 fixes a few more bugs. Only one is a regression—I found the others while testing. In this release:
Fixed
del
, ins
, and s
elements in sanitized HTML.redirect_after_auth_path
on browser navigation.FileUtils.mv
to move uploaded files. (fixes #117)Thanks to @jayvii for help with troubleshooting the last one!